Squash commits and merge latest develop#2792
Open
sf-cboscenco wants to merge 4 commits intofeature/use-bonus-productsfrom
Open
Squash commits and merge latest develop#2792sf-cboscenco wants to merge 4 commits intofeature/use-bonus-productsfrom
sf-cboscenco wants to merge 4 commits intofeature/use-bonus-productsfrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sf-cboscenco
added
skip changelog
sf-shikhar-prasoon
approved these changes
Jul 14, 2025
ddiazccrz
approved these changes
Jul 14, 2025
| src={bundleImage?.link || ''} | ||
| alt={bundleImage?.alt || ''} | ||
| /> | ||
| <img src={bundleImage.link} alt={bundleImage.alt} /> |
Contributor
There was a problem hiding this comment.
Can we add this back, otherwise products with no images will likely throw an error
| src={image?.link || ''} | ||
| alt={image?.alt || ''} | ||
| /> | ||
| <img src={image.link} alt={image.alt} /> |
| src={image?.link || ''} | ||
| alt={image?.alt || ''} | ||
| /> | ||
| <img src={image.link} alt={image.alt} /> |
Contributor
There was a problem hiding this comment.
Same thing here please :)
sf-deepali-bharmal
approved these changes
Jul 14, 2025
Contributor
sf-deepali-bharmal
left a comment
sf-deepali-bharmal
left a comment
There was a problem hiding this comment.
I am assuming we are only updating the feature branch with main branch with no new changes by us.
sf-jhalak-maheshwari
approved these changes
Jul 14, 2025
Contributor
sf-jhalak-maheshwari
left a comment
sf-jhalak-maheshwari
left a comment
There was a problem hiding this comment.
assuming its merging in from feature to main. The work has already been reviewed by team.
sf-kyle-wright
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization